feat: writing logs to the filesystem with rotation support (#1299)

* refactor: move lib/policy/config to lib/config Signed-off-by: Xe Iaso <me@xeiaso.net> * refactor: don't set global loggers anymore Ref #864 You were right @kotx, it is a bad idea to set the global logger instance. Signed-off-by: Xe Iaso <me@xeiaso.net> * feat(config): add log sink support Signed-off-by: Xe Iaso <me@xeiaso.net> * chore: update spelling Signed-off-by: Xe Iaso <me@xeiaso.net> * chore(test): go mod tidy Signed-off-by: Xe Iaso <me@xeiaso.net> * chore: update spelling Signed-off-by: Xe Iaso <me@xeiaso.net> * docs(admin/policies): add logging block documentation Signed-off-by: Xe Iaso <me@xeiaso.net> * docs: update CHANGELOG Signed-off-by: Xe Iaso <me@xeiaso.net> * fix(cmd/anubis): revert this change, it's meant to be its own PR Signed-off-by: Xe Iaso <me@xeiaso.net> * chore: go mod tidy Signed-off-by: Xe Iaso <me@xeiaso.net> * test: add file logging smoke test Assisted-by: GLM 4.6 via Claude Code Signed-off-by: Xe Iaso <me@xeiaso.net> * fix: don't expose the old log file time format string Signed-off-by: Xe Iaso <me@xeiaso.net> --------- Signed-off-by: Xe Iaso <me@xeiaso.net>
2025-11-21 11:46:00 -05:00 · 2025-11-21 11:46:00 -05:00 · f032d5d0ac
commit f032d5d0ac
parent a709a2b2da
118 changed files with 789 additions and 65 deletions
--- a/lib/config/logging_test.go
+++ b/lib/config/logging_test.go
@ -0,0 +1,103 @@
+package config
+
+import (
+	"errors"
+	"testing"
+)
+
+func TestLoggingValid(t *testing.T) {
+	for _, tt := range []struct {
+		name  string
+		input *Logging
+		want  error
+	}{
+		{
+			name:  "simple happy",
+			input: (Logging{}).Default(),
+		},
+		{
+			name: "default file config",
+			input: &Logging{
+				Sink:       LogSinkFile,
+				Parameters: (&LoggingFileConfig{}).Default(),
+			},
+		},
+		{
+			name: "invalid sink",
+			input: &Logging{
+				Sink: "taco invalid",
+			},
+			want: ErrInvalidLoggingSink,
+		},
+		{
+			name: "missing parameters",
+			input: &Logging{
+				Sink: LogSinkFile,
+			},
+			want: ErrMissingLoggingFileConfig,
+		},
+		{
+			name: "invalid parameters",
+			input: &Logging{
+				Sink:       LogSinkFile,
+				Parameters: &LoggingFileConfig{},
+			},
+			want: ErrInvalidLoggingFileConfig,
+		},
+		{
+			name: "file sink with no filename",
+			input: &Logging{
+				Sink: LogSinkFile,
+				Parameters: &LoggingFileConfig{
+					Filename:     "",
+					MaxBackups:   3,
+					MaxBytes:     104857600, // 100 Mi
+					MaxAge:       7,         // 7 days
+					Compress:     true,
+					UseLocalTime: false,
+				},
+			},
+			want: ErrMissingValue,
+		},
+		{
+			name: "file sink with negative max backups",
+			input: &Logging{
+				Sink: LogSinkFile,
+				Parameters: &LoggingFileConfig{
+					Filename:     "./var/anubis.log",
+					MaxBackups:   -3,
+					MaxBytes:     104857600, // 100 Mi
+					MaxAge:       7,         // 7 days
+					Compress:     true,
+					UseLocalTime: false,
+				},
+			},
+			want: ErrOutOfRange,
+		},
+		{
+			name: "file sink with negative max age",
+			input: &Logging{
+				Sink: LogSinkFile,
+				Parameters: &LoggingFileConfig{
+					Filename:     "./var/anubis.log",
+					MaxBackups:   3,
+					MaxBytes:     104857600, // 100 Mi
+					MaxAge:       -7,        // 7 days
+					Compress:     true,
+					UseLocalTime: false,
+				},
+			},
+			want: ErrOutOfRange,
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			err := tt.input.Valid()
+
+			if !errors.Is(err, tt.want) {
+				t.Logf("wanted error: %v", tt.want)
+				t.Logf("   got error: %v", err)
+				t.Fatal("got wrong error")
+			}
+		})
+	}
+}