sophie/nuke
1
0
Fork 0
Code Packages 1 Activity Actions

fix: improve error handling and create the json encoder once #331 (#332)

Browse source 
* fix: improve error handling for resource closing and JSON encoding in MakeChallenge

* chore: update CHANGELOG with recent changes and improvements

* refactor: simplify RenderIndex function and improve error handling

---------

Signed-off-by: Jason Cameron <git@jasoncameron.dev>
This commit is contained in:
Jason Cameron 2025-04-22 20:31:19 -04:00 • committed by GitHub
parent 2db4105479
commit 78bb67fbf7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 48 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/test/playwright_test.go
View file

@ -378,14 +378,14 @@ func pwFail(t *testing.T, page playwright.Page, format string, args ...any) erro
}
func pwTimeout(tc testCase, deadline time.Time) *float64 {
max := *playwrightMaxTime
maxTime := *playwrightMaxTime
if tc.isHard {
max = *playwrightMaxHardTime
maxTime = *playwrightMaxHardTime
}
d := time.Until(deadline)
if d <= 0 || d > max {
return playwright.Float(float64(max.Milliseconds()))
if d <= 0 || d > maxTime {
return playwright.Float(float64(maxTime.Milliseconds()))
}
return playwright.Float(float64(d.Milliseconds()))
}