sophie/nuke
1
0
Fork 0
Code Packages 1 Activity Actions

fix: Dynamic cookie domain not working (#731)

Browse source 
* Fix cookieDynamicDomain option not being set in Options struct

* Fix using wrong cookie name when using dynamic cookie domains

* Adjust testcases for new cookie option structs

* Add known words to expect.txt and change typo in Zombocom

* Cleanup expect.txt

* Add changes to changelog

* Bump versions of grpc and apimachinery

* Fix testcases and add additional condition for dynamic cookie domain
This commit is contained in:
Martin 2025-06-29 21:38:55 +02:00 • committed by GitHub
parent b1edf84a7c
commit 6aa17532da
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 98 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/anubis_test.go
View file

@ -189,8 +189,6 @@ func TestCVE2025_24369(t *testing.T) {
srv := spawnAnubis(t, Options{
Next: http.NewServeMux(),
Policy: pol,
CookieName: t.Name(),
})
ts := httptest.NewServer(internal.RemoteXRealIP(true, "tcp", srv))
@ -235,13 +233,13 @@ func TestCookieCustomExpiration(t *testing.T) {
var ckie *http.Cookie
for _, cookie := range resp.Cookies() {
t.Logf("%#v", cookie)
if cookie.Name == srv.cookieName {
if cookie.Name == anubis.CookieName {
ckie = cookie
break
}
}
if ckie == nil {
t.Errorf("Cookie %q not found", srv.cookieName)
t.Errorf("Cookie %q not found", anubis.CookieName)
return
}
@ -264,7 +262,6 @@ func TestCookieSettings(t *testing.T) {
CookieDomain: "127.0.0.1",
CookiePartitioned: true,
CookieName: t.Name(),
CookieExpiration: anubis.CookieDefaultExpirationTime,
})
@ -286,13 +283,13 @@ func TestCookieSettings(t *testing.T) {
var ckie *http.Cookie
for _, cookie := range resp.Cookies() {
t.Logf("%#v", cookie)
if cookie.Name == srv.cookieName {
if cookie.Name == anubis.CookieName {
ckie = cookie
break
}
}
if ckie == nil {
t.Errorf("Cookie %q not found", srv.cookieName)
t.Errorf("Cookie %q not found", anubis.CookieName)
return
}
@ -619,7 +616,6 @@ func TestRuleChange(t *testing.T) {
Policy: pol,
CookieDomain: "127.0.0.1",
CookieName: t.Name(),
CookieExpiration: ckieExpiration,
})