fix(internal/thoth): don't block Anubis starting if healthcheck fails (#794)
Signed-off-by: Xe Iaso <me@xeiaso.net>
This commit is contained in:
parent
cc56baa5c7
commit
3c739c1305
2 changed files with 2 additions and 10 deletions
|
|
@ -99,6 +99,7 @@ There are a bunch of other assorted features and fixes too:
|
||||||
- Make the [Open Graph](./admin/configuration/open-graph.mdx) subsystem and DNSBL subsystem use [storage backends](./admin/policies.mdx#storage-backends) instead of storing everything in memory by default.
|
- Make the [Open Graph](./admin/configuration/open-graph.mdx) subsystem and DNSBL subsystem use [storage backends](./admin/policies.mdx#storage-backends) instead of storing everything in memory by default.
|
||||||
- Allow [Common Crawl](https://commoncrawl.org/) by default so scrapers have less incentive to scrape
|
- Allow [Common Crawl](https://commoncrawl.org/) by default so scrapers have less incentive to scrape
|
||||||
- The [bbolt storage backend](./admin/policies.mdx#bbolt) now runs its cleanup every hour instead of every five minutes.
|
- The [bbolt storage backend](./admin/policies.mdx#bbolt) now runs its cleanup every hour instead of every five minutes.
|
||||||
|
- Don't block Anubis starting up if [Thoth](./admin/thoth.mdx) health checks fail.
|
||||||
|
|
||||||
### Potentially breaking changes
|
### Potentially breaking changes
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -60,15 +60,6 @@ func New(ctx context.Context, thothURL, apiToken string, plaintext bool) (*Clien
|
||||||
|
|
||||||
hc := healthv1.NewHealthClient(conn)
|
hc := healthv1.NewHealthClient(conn)
|
||||||
|
|
||||||
resp, err := hc.Check(ctx, &healthv1.HealthCheckRequest{})
|
|
||||||
if err != nil {
|
|
||||||
return nil, fmt.Errorf("can't verify thoth health at %s: %w", thothURL, err)
|
|
||||||
}
|
|
||||||
|
|
||||||
if resp.Status != healthv1.HealthCheckResponse_SERVING {
|
|
||||||
return nil, fmt.Errorf("thoth is not healthy, wanted %s but got %s", healthv1.HealthCheckResponse_SERVING, resp.Status)
|
|
||||||
}
|
|
||||||
|
|
||||||
return &Client{
|
return &Client{
|
||||||
conn: conn,
|
conn: conn,
|
||||||
health: hc,
|
health: hc,
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue